de4dot-cex/de4dot.code/renamer/asmmodules/TypeDef.cs

/*
    Copyright (C) 2011-2012 de4dot@gmail.com

    This file is part of de4dot.

    de4dot is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    de4dot is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with de4dot.  If not, see <http://www.gnu.org/licenses/>.
*/

using System;
using System.Collections.Generic;
using dot10.DotNet;
using de4dot.blocks;

namespace de4dot.code.renamer.asmmodules {
	class TypeInfo {
		public ITypeDefOrRef typeReference;
		public MTypeDef typeDef;
		public TypeInfo(ITypeDefOrRef typeReference, MTypeDef typeDef) {
			this.typeReference = typeReference;
			this.typeDef = typeDef;
		}

		public TypeInfo(TypeInfo other, GenericInstSig git) {
			this.typeReference = GenericArgsSubstitutor.create(other.typeReference, git);
			this.typeDef = other.typeDef;
		}

		public override int GetHashCode() {
			return typeDef.GetHashCode() +
					new SigComparer().GetHashCode(typeReference);
		}

		public override bool Equals(object obj) {
			var other = obj as TypeInfo;
			if (other == null)
				return false;
			return typeDef == other.typeDef &&
				new SigComparer().Equals(typeReference, other.typeReference);
		}

		public override string ToString() {
			return typeReference.ToString();
		}
	}

	class MethodDefKey {
		public readonly MMethodDef methodDef;

		public MethodDefKey(MMethodDef methodDef) {
			this.methodDef = methodDef;
		}

		public override int GetHashCode() {
			return MethodEqualityComparer.CompareDeclaringTypes.GetHashCode(methodDef.MethodDef);
		}

		public override bool Equals(object obj) {
			var other = obj as MethodDefKey;
			if (other == null)
				return false;
			return MethodEqualityComparer.CompareDeclaringTypes.Equals(methodDef.MethodDef, other.methodDef.MethodDef);
		}
	}

	class MethodInst {
		public MMethodDef origMethodDef;
		public IMethodDefOrRef methodReference;

		public MethodInst(MMethodDef origMethodDef, IMethodDefOrRef methodReference) {
			this.origMethodDef = origMethodDef;
			this.methodReference = methodReference;
		}

		public override string ToString() {
			return methodReference.ToString();
		}
	}

	class MethodInstances {
		Dictionary<IMethodDefOrRef, List<MethodInst>> methodInstances = new Dictionary<IMethodDefOrRef, List<MethodInst>>(MethodEqualityComparer.DontCompareDeclaringTypes);

		public void initializeFrom(MethodInstances other, GenericInstSig git) {
			foreach (var list in other.methodInstances.Values) {
				foreach (var methodInst in list) {
					var newMethod = GenericArgsSubstitutor.create(methodInst.methodReference, git);
					add(new MethodInst(methodInst.origMethodDef, newMethod));
				}
			}
		}

		public void add(MethodInst methodInst) {
			List<MethodInst> list;
			var key = methodInst.methodReference;
			if (methodInst.origMethodDef.isNewSlot() || !methodInstances.TryGetValue(key, out list))
				methodInstances[key] = list = new List<MethodInst>();
			list.Add(methodInst);
		}

		public List<MethodInst> lookup(IMethodDefOrRef methodReference) {
			List<MethodInst> list;
			methodInstances.TryGetValue(methodReference, out list);
			return list;
		}

		public IEnumerable<List<MethodInst>> getMethods() {
			return methodInstances.Values;
		}
	}

	// Keeps track of which methods of an interface that have been implemented
	class InterfaceMethodInfo {
		TypeInfo iface;
		Dictionary<MethodDefKey, MMethodDef> ifaceMethodToClassMethod = new Dictionary<MethodDefKey, MMethodDef>();

		public TypeInfo IFace {
			get { return iface; }
		}

		public Dictionary<MethodDefKey, MMethodDef> IfaceMethodToClassMethod {
			get { return ifaceMethodToClassMethod; }
		}

		public InterfaceMethodInfo(TypeInfo iface) {
			this.iface = iface;
			foreach (var methodDef in iface.typeDef.AllMethods)
				ifaceMethodToClassMethod[new MethodDefKey(methodDef)] = null;
		}

		public InterfaceMethodInfo(TypeInfo iface, InterfaceMethodInfo other) {
			this.iface = iface;
			foreach (var key in other.ifaceMethodToClassMethod.Keys)
				ifaceMethodToClassMethod[key] = other.ifaceMethodToClassMethod[key];
		}

		public void merge(InterfaceMethodInfo other) {
			foreach (var key in other.ifaceMethodToClassMethod.Keys) {
				if (other.ifaceMethodToClassMethod[key] == null)
					continue;
				if (ifaceMethodToClassMethod[key] != null)
					throw new ApplicationException("Interface method already initialized");
				ifaceMethodToClassMethod[key] = other.ifaceMethodToClassMethod[key];
			}
		}

		// Returns the previous method, or null if none
		public MMethodDef addMethod(MMethodDef ifaceMethod, MMethodDef classMethod) {
			var ifaceKey = new MethodDefKey(ifaceMethod);
			if (!ifaceMethodToClassMethod.ContainsKey(ifaceKey))
				throw new ApplicationException("Could not find interface method");

			MMethodDef oldMethod;
			ifaceMethodToClassMethod.TryGetValue(ifaceKey, out oldMethod);
			ifaceMethodToClassMethod[ifaceKey] = classMethod;
			return oldMethod;
		}

		public void addMethodIfEmpty(MMethodDef ifaceMethod, MMethodDef classMethod) {
			if (ifaceMethodToClassMethod[new MethodDefKey(ifaceMethod)] == null)
				addMethod(ifaceMethod, classMethod);
		}

		public override string ToString() {
			return iface.ToString();
		}
	}

	class InterfaceMethodInfos {
		Dictionary<ITypeDefOrRef, InterfaceMethodInfo> interfaceMethods = new Dictionary<ITypeDefOrRef, InterfaceMethodInfo>(TypeEqualityComparer.Instance);

		public IEnumerable<InterfaceMethodInfo> AllInfos {
			get { return interfaceMethods.Values; }
		}

		public void initializeFrom(InterfaceMethodInfos other, GenericInstSig git) {
			foreach (var pair in other.interfaceMethods) {
				var oldTypeInfo = pair.Value.IFace;
				var newTypeInfo = new TypeInfo(oldTypeInfo, git);
				var oldKey = oldTypeInfo.typeReference;
				var newKey = newTypeInfo.typeReference;

				InterfaceMethodInfo newMethodsInfo = new InterfaceMethodInfo(newTypeInfo, other.interfaceMethods[oldKey]);
				if (interfaceMethods.ContainsKey(newKey))
					newMethodsInfo.merge(interfaceMethods[newKey]);
				interfaceMethods[newKey] = newMethodsInfo;
			}
		}

		public void addInterface(TypeInfo iface) {
			var key = iface.typeReference;
			if (!interfaceMethods.ContainsKey(key))
				interfaceMethods[key] = new InterfaceMethodInfo(iface);
		}

		// Returns the previous classMethod, or null if none
		public MMethodDef addMethod(TypeInfo iface, MMethodDef ifaceMethod, MMethodDef classMethod) {
			return addMethod(iface.typeReference, ifaceMethod, classMethod);
		}

		// Returns the previous classMethod, or null if none
		public MMethodDef addMethod(ITypeDefOrRef iface, MMethodDef ifaceMethod, MMethodDef classMethod) {
			InterfaceMethodInfo info;
			if (!interfaceMethods.TryGetValue(iface, out info))
				throw new ApplicationException("Could not find interface");
			return info.addMethod(ifaceMethod, classMethod);
		}

		public void addMethodIfEmpty(TypeInfo iface, MMethodDef ifaceMethod, MMethodDef classMethod) {
			InterfaceMethodInfo info;
			if (!interfaceMethods.TryGetValue(iface.typeReference, out info))
				throw new ApplicationException("Could not find interface");
			info.addMethodIfEmpty(ifaceMethod, classMethod);
		}
	}

	class MTypeDef : Ref {
		EventDefDict events = new EventDefDict();
		FieldDefDict fields = new FieldDefDict();
		MethodDefDict methods = new MethodDefDict();
		PropertyDefDict properties = new PropertyDefDict();
		TypeDefDict types = new TypeDefDict();
		List<MGenericParamDef> genericParams;
		internal TypeInfo baseType = null;
		internal IList<TypeInfo> interfaces = new List<TypeInfo>();	// directly implemented interfaces
		internal IList<MTypeDef> derivedTypes = new List<MTypeDef>();
		Module module;

		bool initializeVirtualMembersCalled = false;
		MethodInstances virtualMethodInstances = new MethodInstances();
		Dictionary<TypeInfo, bool> allImplementedInterfaces = new Dictionary<TypeInfo, bool>();
		InterfaceMethodInfos interfaceMethodInfos = new InterfaceMethodInfos();

		public Module Module {
			get { return module; }
		}

		// Returns false if this is a type from a dependency (non-renamble) assembly (eg. mscorlib)
		public bool HasModule {
			get { return module != null; }
		}

		public IList<MGenericParamDef> GenericParams {
			get { return genericParams; }
		}

		public IEnumerable<MTypeDef> NestedTypes {
			get { return types.getSorted(); }
		}

		public MTypeDef NestingType { get; set; }

		public TypeDef TypeDef {
			get { return (TypeDef)memberReference; }
		}

		public IEnumerable<MEventDef> AllEvents {
			get { return events.getValues(); }
		}

		public IEnumerable<MFieldDef> AllFields {
			get { return fields.getValues(); }
		}

		public IEnumerable<MMethodDef> AllMethods {
			get { return methods.getValues(); }
		}

		public IEnumerable<MPropertyDef> AllProperties {
			get { return properties.getValues(); }
		}

		public IEnumerable<MEventDef> AllEventsSorted {
			get { return events.getSorted(); }
		}

		public IEnumerable<MFieldDef> AllFieldsSorted {
			get { return fields.getSorted(); }
		}

		public IEnumerable<MMethodDef> AllMethodsSorted {
			get { return methods.getSorted(); }
		}

		public IEnumerable<MPropertyDef> AllPropertiesSorted {
			get { return properties.getSorted(); }
		}

		public MTypeDef(TypeDef typeDefinition, Module module, int index)
			: base(typeDefinition, null, index) {
			this.module = module;
			genericParams = MGenericParamDef.createGenericParamDefList(TypeDef.GenericParams);
		}

		public void addInterface(MTypeDef ifaceDef, ITypeDefOrRef iface) {
			if (ifaceDef == null || iface == null)
				return;
			interfaces.Add(new TypeInfo(iface, ifaceDef));
		}

		public void addBaseType(MTypeDef baseDef, ITypeDefOrRef baseRef) {
			if (baseDef == null || baseRef == null)
				return;
			baseType = new TypeInfo(baseRef, baseDef);
		}

		public void add(MEventDef e) {
			events.add(e);
		}

		public void add(MFieldDef f) {
			fields.add(f);
		}

		public void add(MMethodDef m) {
			methods.add(m);
		}

		public void add(MPropertyDef p) {
			properties.add(p);
		}

		public void add(MTypeDef t) {
			types.add(t);
		}

		public MMethodDef findMethod(MemberRef mr) {
			return methods.find(mr);
		}

		public MMethodDef findMethod(IMethodDefOrRef md) {
			return methods.find(md);
		}

		public MMethodDef findMethod(MethodDef md) {
			return methods.find(md);
		}

		public MMethodDef findAnyMethod(MemberRef mr) {
			return methods.findAny(mr);
		}

		public MFieldDef findField(MemberRef fr) {
			return fields.find(fr);
		}

		public MFieldDef findAnyField(MemberRef fr) {
			return fields.findAny(fr);
		}

		public MPropertyDef find(PropertyDef pr) {
			return properties.find(pr);
		}

		public MPropertyDef findAny(PropertyDef pr) {
			return properties.findAny(pr);
		}

		public MEventDef find(EventDef er) {
			return events.find(er);
		}

		public MEventDef findAny(EventDef er) {
			return events.findAny(er);
		}

		public MPropertyDef create(PropertyDef newProp) {
			if (findAny(newProp) != null)
				throw new ApplicationException("Can't add a property when it's already been added");

			var propDef = new MPropertyDef(newProp, this, properties.Count);
			add(propDef);
			TypeDef.Properties.Add(newProp);
			return propDef;
		}

		public MEventDef create(EventDef newEvent) {
			if (findAny(newEvent) != null)
				throw new ApplicationException("Can't add an event when it's already been added");

			var eventDef = new MEventDef(newEvent, this, events.Count);
			add(eventDef);
			TypeDef.Events.Add(newEvent);
			return eventDef;
		}

		public void addMembers() {
			var type = TypeDef;

			for (int i = 0; i < type.Events.Count; i++)
				add(new MEventDef(type.Events[i], this, i));
			for (int i = 0; i < type.Fields.Count; i++)
				add(new MFieldDef(type.Fields[i], this, i));
			for (int i = 0; i < type.Methods.Count; i++)
				add(new MMethodDef(type.Methods[i], this, i));
			for (int i = 0; i < type.Properties.Count; i++)
				add(new MPropertyDef(type.Properties[i], this, i));

			foreach (var propDef in properties.getValues()) {
				foreach (var method in propDef.methodDefinitions()) {
					var methodDef = findMethod(method);
					if (methodDef == null)
						throw new ApplicationException("Could not find property method");
					methodDef.Property = propDef;
					if (method == propDef.PropertyDef.GetMethod)
						propDef.GetMethod = methodDef;
					if (method == propDef.PropertyDef.SetMethod)
						propDef.SetMethod = methodDef;
				}
			}

			foreach (var eventDef in events.getValues()) {
				foreach (var method in eventDef.methodDefinitions()) {
					var methodDef = findMethod(method);
					if (methodDef == null)
						throw new ApplicationException("Could not find event method");
					methodDef.Event = eventDef;
					if (method == eventDef.EventDef.AddMethod)
						eventDef.AddMethod = methodDef;
					if (method == eventDef.EventDef.RemoveMethod)
						eventDef.RemoveMethod = methodDef;
					if (method == eventDef.EventDef.InvokeMethod)
						eventDef.RaiseMethod = methodDef;
				}
			}
		}

		public void onTypesRenamed() {
			events.onTypesRenamed();
			properties.onTypesRenamed();
			fields.onTypesRenamed();
			methods.onTypesRenamed();
			types.onTypesRenamed();
		}

		public bool isNested() {
			return NestingType != null;
		}

		public bool isGlobalType() {
			if (!isNested())
				return TypeDef.IsPublic;
			switch (TypeDef.Visibility) {
			case TypeAttributes.NestedPrivate:
			case TypeAttributes.NestedAssembly:
			case TypeAttributes.NestedFamANDAssem:
				return false;
			case TypeAttributes.NestedPublic:
			case TypeAttributes.NestedFamily:
			case TypeAttributes.NestedFamORAssem:
				return NestingType.isGlobalType();
			default:
				return false;
			}
		}

		public void initializeVirtualMembers(MethodNameGroups groups, IResolver resolver) {
			if (initializeVirtualMembersCalled)
				return;
			initializeVirtualMembersCalled = true;

			foreach (var iface in interfaces)
				iface.typeDef.initializeVirtualMembers(groups, resolver);
			if (baseType != null)
				baseType.typeDef.initializeVirtualMembers(groups, resolver);

			foreach (var methodDef in methods.getValues()) {
				if (methodDef.isVirtual())
					groups.add(methodDef);
			}

			instantiateVirtualMembers(groups);
			initializeInterfaceMethods(groups);
		}

		void initializeAllInterfaces() {
			if (baseType != null)
				initializeInterfaces(baseType);

			foreach (var iface in interfaces) {
				allImplementedInterfaces[iface] = true;
				interfaceMethodInfos.addInterface(iface);
				initializeInterfaces(iface);
			}
		}

		void initializeInterfaces(TypeInfo typeInfo) {
			var git = typeInfo.typeReference.ToGenericInstSig();
			interfaceMethodInfos.initializeFrom(typeInfo.typeDef.interfaceMethodInfos, git);
			foreach (var info in typeInfo.typeDef.allImplementedInterfaces.Keys) {
				var newTypeInfo = new TypeInfo(info, git);
				allImplementedInterfaces[newTypeInfo] = true;
			}
		}

		void initializeInterfaceMethods(MethodNameGroups groups) {
			initializeAllInterfaces();

			if (TypeDef.IsInterface)
				return;

			//--- Partition II 12.2 Implementing virtual methods on interfaces:
			//--- The VES shall use the following algorithm to determine the appropriate
			//--- implementation of an interface's virtual abstract methods:
			//---
			//--- * If the base class implements the interface, start with the same virtual methods
			//---	that it provides; otherwise, create an interface that has empty slots for all
			//---	virtual functions.
			// Done. See initializeAllInterfaces().

			var methodsDict = new Dictionary<IMethodDefOrRef, MMethodDef>(MethodEqualityComparer.DontCompareDeclaringTypes);

			//--- * If this class explicitly specifies that it implements the interface (i.e., the
			//---	interfaces that appear in this class‘ InterfaceImpl table, §22.23)
			//---	* If the class defines any public virtual newslot methods whose name and
			//---	  signature match a virtual method on the interface, then use these new virtual
			//---	  methods to implement the corresponding interface method.
			if (interfaces.Count > 0) {
				methodsDict.Clear();
				foreach (var method in methods.getValues()) {
					if (!method.isPublic() || !method.isVirtual() || !method.isNewSlot())
						continue;
					methodsDict[method.MethodDef] = method;
				}

				foreach (var ifaceInfo in interfaces) {
					foreach (var methodsList in ifaceInfo.typeDef.virtualMethodInstances.getMethods()) {
						if (methodsList.Count < 1)
							continue;
						var methodInst = methodsList[0];
						var ifaceMethod = methodInst.origMethodDef;
						if (!ifaceMethod.isVirtual())
							continue;
						var ifaceMethodReference = GenericArgsSubstitutor.create(methodInst.methodReference, ifaceInfo.typeReference.ToGenericInstSig());
						MMethodDef classMethod;
						if (!methodsDict.TryGetValue(ifaceMethodReference, out classMethod))
							continue;
						interfaceMethodInfos.addMethod(ifaceInfo, ifaceMethod, classMethod);
					}
				}
			}

			//--- * If there are any virtual methods in the interface that still have empty slots,
			//---	see if there are any public virtual methods, but not public virtual newslot
			//---	methods, available on this class (directly or inherited) having the same name
			//---	and signature, then use these to implement the corresponding methods on the
			//---	interface.
			methodsDict.Clear();
			foreach (var methodInstList in virtualMethodInstances.getMethods()) {
				// This class' method is at the end
				for (int i = methodInstList.Count - 1; i >= 0; i--) {
					var classMethod = methodInstList[i];
					// These methods are guaranteed to be virtual.
					// We should allow newslot methods, despite what the official doc says.
					if (!classMethod.origMethodDef.isPublic())
						continue;
					methodsDict[classMethod.methodReference] = classMethod.origMethodDef;
					break;
				}
			}
			foreach (var ifaceInfo in allImplementedInterfaces.Keys) {
				foreach (var methodsList in ifaceInfo.typeDef.virtualMethodInstances.getMethods()) {
					if (methodsList.Count < 1)
						continue;
					var ifaceMethod = methodsList[0].origMethodDef;
					if (!ifaceMethod.isVirtual())
						continue;
					var ifaceMethodRef = GenericArgsSubstitutor.create(ifaceMethod.MethodDef, ifaceInfo.typeReference.ToGenericInstSig());
					MMethodDef classMethod;
					if (!methodsDict.TryGetValue(ifaceMethodRef, out classMethod))
						continue;
					interfaceMethodInfos.addMethodIfEmpty(ifaceInfo, ifaceMethod, classMethod);
				}
			}

			//--- * Apply all MethodImpls that are specified for this class, thereby placing
			//---	explicitly specified virtual methods into the interface in preference to those
			//---	inherited or chosen by name matching.
			methodsDict.Clear();
			var ifaceMethodsDict = new Dictionary<IMethodDefOrRef, MMethodDef>(MethodEqualityComparer.CompareDeclaringTypes);
			foreach (var ifaceInfo in allImplementedInterfaces.Keys) {
				var git = ifaceInfo.typeReference.ToGenericInstSig();
				foreach (var ifaceMethod in ifaceInfo.typeDef.methods.getValues()) {
					IMethodDefOrRef ifaceMethodReference = ifaceMethod.MethodDef;
					if (git != null)
						ifaceMethodReference = simpleClone(ifaceMethod.MethodDef, ifaceInfo.typeReference);
					ifaceMethodsDict[ifaceMethodReference] = ifaceMethod;
				}
			}
			foreach (var classMethod in methods.getValues()) {
				if (!classMethod.isVirtual())
					continue;
				foreach (var overrideMethod in classMethod.MethodDef.Overrides) {
					MMethodDef ifaceMethod;
					if (!ifaceMethodsDict.TryGetValue(overrideMethod.MethodDeclaration, out ifaceMethod)) {
						// We couldn't find the interface method (eg. interface not resolved) or
						// it overrides a base class method, and not an interface method.
						continue;
					}

					interfaceMethodInfos.addMethod(overrideMethod.MethodDeclaration.DeclaringType, ifaceMethod, classMethod);
				}
			}

			//--- * If the current class is not abstract and there are any interface methods that
			//---	still have empty slots, then the program is invalid.
			// Check it anyway. C# requires a method, even if it's abstract. I don't think anyone
			// writes pure CIL assemblies.
			foreach (var info in interfaceMethodInfos.AllInfos) {
				foreach (var pair in info.IfaceMethodToClassMethod) {
					if (pair.Value != null)
						continue;
					if (!resolvedAllInterfaces() || !resolvedBaseClasses())
						continue;
					// Ignore if COM class
					if (!TypeDef.IsImport &&
						!hasAttribute("System.Runtime.InteropServices.ComImportAttribute") &&
						!hasAttribute("System.Runtime.InteropServices.TypeLibTypeAttribute")) {
						Log.w("Could not find interface method {0} ({1:X8}). Type: {2} ({3:X8})",
								Utils.removeNewlines(pair.Key.methodDef.MethodDef),
								pair.Key.methodDef.MethodDef.MDToken.ToInt32(),
								Utils.removeNewlines(TypeDef),
								TypeDef.MDToken.ToInt32());
					}
				}
			}

			foreach (var info in interfaceMethodInfos.AllInfos) {
				foreach (var pair in info.IfaceMethodToClassMethod) {
					if (pair.Value == null)
						continue;
					if (pair.Key.methodDef.MethodDef.Name != pair.Value.MethodDef.Name)
						continue;
					groups.same(pair.Key.methodDef, pair.Value);
				}
			}
		}

		bool hasAttribute(string name) {
			foreach (var attr in TypeDef.CustomAttributes) {
				if (attr.TypeFullName == name)
					return true;
			}
			return false;
		}

		// Returns true if all interfaces have been resolved
		bool? resolvedAllInterfacesResult;
		bool resolvedAllInterfaces() {
			if (!resolvedAllInterfacesResult.HasValue) {
				resolvedAllInterfacesResult = true;	// If we find a circular reference
				resolvedAllInterfacesResult = resolvedAllInterfacesInternal();
			}
			return resolvedAllInterfacesResult.Value;
		}
		bool resolvedAllInterfacesInternal() {
			if (TypeDef.InterfaceImpls.Count != interfaces.Count)
				return false;
			foreach (var ifaceInfo in interfaces) {
				if (!ifaceInfo.typeDef.resolvedAllInterfaces())
					return false;
			}
			return true;
		}

		// Returns true if all base classes have been resolved
		bool? resolvedBaseClassesResult;
		bool resolvedBaseClasses() {
			if (!resolvedBaseClassesResult.HasValue) {
				resolvedBaseClassesResult = true;	// If we find a circular reference
				resolvedBaseClassesResult = resolvedBaseClassesInternal();
			}
			return resolvedBaseClassesResult.Value;
		}
		bool resolvedBaseClassesInternal() {
			if (TypeDef.BaseType == null)
				return true;
			if (baseType == null)
				return false;
			return baseType.typeDef.resolvedBaseClasses();
		}

		MemberRef simpleClone(MethodDef methodRef, ITypeDefOrRef declaringType) {
			if (module == null)
				return new MemberRefUser(null, methodRef.Name, methodRef.MethodSig, declaringType);
			var mr = new MemberRefUser(module.ModuleDefMD, methodRef.Name, methodRef.MethodSig, declaringType);
			return module.ModuleDefMD.UpdateRowId(mr);
		}

		void instantiateVirtualMembers(MethodNameGroups groups) {
			if (!TypeDef.IsInterface) {
				if (baseType != null)
					virtualMethodInstances.initializeFrom(baseType.typeDef.virtualMethodInstances, baseType.typeReference.ToGenericInstSig());

				// Figure out which methods we override in the base class
				foreach (var methodDef in methods.getValues()) {
					if (!methodDef.isVirtual() || methodDef.isNewSlot())
						continue;
					var methodInstList = virtualMethodInstances.lookup(methodDef.MethodDef);
					if (methodInstList == null)
						continue;
					foreach (var methodInst in methodInstList)
						groups.same(methodDef, methodInst.origMethodDef);
				}
			}

			foreach (var methodDef in methods.getValues()) {
				if (!methodDef.isVirtual())
					continue;
				virtualMethodInstances.add(new MethodInst(methodDef, methodDef.MethodDef));
			}
		}
	}
}